ADL Updates for errors and new endpoints #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
begoldsm
commented
May 18, 2016
begoldsm
commented
- Add DeleteAllSecrets (was a regression miss from hyak)
- Update Filesystem errors to reflect the types of errors thrown
- Fix json for InnerError -> innerError in job api (this is due to a fix finally happening on the server side)
- Add the ability to get partition information through the catalog APIs
- Add missing enum values
- Fix some documentation.
added 30 commits
March 24, 2016 13:32
These clients don't need a subscriptionId.
Will add extensions that make it optional in C# and zero it out to an empty stream.
Issue: Azure/autorest#884 is tracking support for this being an optional param properly and not resulting in a null reference. So I will keep this spec as is.
Makes this more obvious to end users and easier to understand.
This API version changes the format for dates and timespan objects to be ISO compliant.
We need a way to have template parameters not be required when they are in the host. I will work with Amar for this next week.
This reverts commit be8b7bf.
Switch over to MSLISTSTATUS which gives more flexibility for listing files/folders.
explicitly calling out our chunked transfer APIs until issue: Azure/autorest#903 is resolved.
In hyak, we could do this by simply excluding the parameter. That is not swagger compliant, so we need a separate entry.
this will be in the next snap.
This was missing during the port from Hyak.
added 22 commits
May 9, 2016 11:09
InnerError fixed to innerError Adding the WebHDFS definition for ErrorResponses to the filesystem.
This should help reduce the levels of nesting and also fixes some feedback in the job swagger.
Removing WebHdfsError and renaming "RemoteException"
Add a placeholder property at the root level which should get properly picked up.
Slight change to the stub property.
| "$ref": "#/definitions/USqlTablePartitionList" | ||
| } | ||
| } | ||
| }, |
There was a problem hiding this comment.
Not sure what the question is here. We support x-ms-odata types for one type "USqlType", but that is not at this line. Do I need to include it everywhere?
There was a problem hiding this comment.
As per the doc the x-ms-odata extension is applied on the operation and not on the type. This will indicate AutoRest that it needs to handle odata parameters in a special way. As this operation has odata parameters and the x-ms-odata extension was missing hence high highlighted it.
@markcowl, @hovsepm - is my understanding correct?
added 3 commits
May 19, 2016 11:19
I thought I had removed this previously. removing it again, since it should no longer be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.